-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-dev): when feedback button is pressed hide buttons #18141
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Works well but the toast is on the complete opposite of the screen from the buttons. Even though I know the toast exists I missed it on a large screen :P Maybe it could be centered? |
Instead of a toast, I'd replace the feedback buttons after they are pressed. We don't want them to be pressed twice so we should just remove them. |
7a01e0f
to
c69accc
Compare
8e8f527
to
f00ef3c
Compare
@FrozenPandaz I replaced the toast with your suggestion which makes more sense! :) |
f00ef3c
to
bdf0398
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
A user clicks the feedback button and there's no indication of whether the feedback went through.
Expected Behavior
There should be some sort of indication that the feedback went through.
Step 1 - Click button:
Step 2 - Buttons disappear - "Thank you for your feedback" is displayed
Notes
I think this can be considered a temporary solution while we're still working with this existing UI. When we switch to a more designed, chat-like interface, maybe this can be integrated in there?