Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): when feedback button is pressed hide buttons #18141

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Jul 17, 2023

Current Behavior

A user clicks the feedback button and there's no indication of whether the feedback went through.

Expected Behavior

There should be some sort of indication that the feedback went through.

Step 1 - Click button:
Screenshot 2023-08-02 at 1 25 24 PM

Step 2 - Buttons disappear - "Thank you for your feedback" is displayed
Screenshot 2023-08-02 at 1 25 28 PM

Notes

I think this can be considered a temporary solution while we're still working with this existing UI. When we switch to a more designed, chat-like interface, maybe this can be integrated in there?

@mandarini mandarini self-assigned this Jul 17, 2023
@mandarini mandarini requested a review from a team as a code owner July 17, 2023 13:53
@mandarini mandarini requested a review from bcabanes July 17, 2023 13:53
@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 10:33am

@MaxKless
Copy link
Collaborator

Works well but the toast is on the complete opposite of the screen from the buttons. Even though I know the toast exists I missed it on a large screen :P Maybe it could be centered?

@FrozenPandaz
Copy link
Collaborator

Instead of a toast, I'd replace the feedback buttons after they are pressed. We don't want them to be pressed twice so we should just remove them.

@mandarini mandarini force-pushed the feat/toast-ai-docs-feedback branch from 7a01e0f to c69accc Compare August 2, 2023 10:10
@mandarini mandarini force-pushed the feat/toast-ai-docs-feedback branch 2 times, most recently from 8e8f527 to f00ef3c Compare August 2, 2023 10:26
@mandarini
Copy link
Member Author

@FrozenPandaz I replaced the toast with your suggestion which makes more sense! :)

@mandarini mandarini requested a review from FrozenPandaz August 2, 2023 10:28
@mandarini mandarini force-pushed the feat/toast-ai-docs-feedback branch from f00ef3c to bdf0398 Compare August 2, 2023 10:29
@mandarini mandarini changed the title feat(nx-dev): show a toast every time feedback button is pressed feat(nx-dev): when feedback button is pressed hide buttons Aug 2, 2023
@mandarini mandarini merged commit ccad52e into nrwl:master Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
@mandarini mandarini deleted the feat/toast-ai-docs-feedback branch August 22, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants