feat(misc): add alternative implementation to calculate buildable dependencies using the task graph #18125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8c73203. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
js/calculate-deps-using-task-graph
branch
from
7d4c314 to
e29f765
Compare
…dencies using the task graph
leosvelperez
force-pushed
the
js/calculate-deps-using-task-graph
branch
from
e29f765 to
8c73203
Compare
leosvelperez
changed the title
jaysoo
approved these changes
Jul 19, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to calculate the buildable dependencies for incremental builds scenarios using the task graph. It's disabled by default and can be enabled setting the
NX_BUILDABLE_LIBRARIES_TASK_GRAPH=trueenvironment variable. This will allow us to test it first and identify potential gaps or issues that could break current setups. When we're happy with it, we'll turn it on by default and eventually, we'll remove the old implementation.Current Behavior
Nx executors supporting incremental builds require the dependencies to have a build target with the same name as the initial project's build target name.
Expected Behavior
Nx executors supporting incremental builds should use the task graph information, which contains the dependencies between targets. This is more reliable and eliminates the need to name the targets with the same name.
Related Issue(s)
Fixes #17764