Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove fatal: no path specified logs from daemon #18117

Merged

Conversation

Cammisuli
Copy link
Member

Current Behavior

When checking to see if files are ignored, we call git. But when the daemon first starts, there's no specific files that are changed, and we get a fatal call from git

Expected Behavior

Check to see if the files array is empty before trying to call git

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested a review from a team as a code owner July 14, 2023 12:18
@Cammisuli Cammisuli requested a review from AgentEnder July 14, 2023 12:18
@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 0:20am

@nx-cloud
Copy link

nx-cloud bot commented Jul 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d656977. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz merged commit b61373a into nrwl:master Jul 14, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants