fix(core): check if socketMessenger is null before using #18116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested changes
Jul 19, 2023
Cammisuli
force-pushed
the
handle-null-socket
branch
from
a0eb516 to
74baa41
Compare
FrozenPandaz
approved these changes
Jul 20, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 20, 2023
(cherry picked from commit eecbde5)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In certain scenarios in Nx Console, the daemon gets reset while a request was about to be sent through with the socketmessenger. When the daemon resets, SocketMessenger is set to null, and we get
TypeError: Cannot read properties of null ("sendMessage")Expected Behavior
We now use the
?operator to make sure we don't call sendMessage on a null messengerRelated Issue(s)
Fixes #