Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): add clickable project edge file links in nx console #18113

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Jul 14, 2023

Description

Currently, the graph integration in Nx Console ends once you open the graph. This PR allows simple bidirectional communication by allowing you to click file links and open them in your IDE.

Implementation

  • repaired the previously unused renderMode handling in the graph service. This allows us to specify window.environment = 'nx-console' when loading the graph html in Nx Console
  • if we're inside Nx Console, make the files in ProjectEdgeNodeTooltip clickable and dispatch a new FileLinkClick event on click
  • set up a new function externalApi.registerFileClickCallback that allows us to listen to these events in nx console and open the specific files

The Nx Console side of things is handled in this PR: nrwl/nx-console#1823

@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 8:17am

@nx-cloud
Copy link

nx-cloud bot commented Jul 14, 2023

@MaxKless MaxKless marked this pull request as ready for review July 25, 2023 08:11
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants