Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): merge None and TS stacks into one since they are both for TS/JS projects #18108

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jul 13, 2023

This PR combines the TS stack into None. The merged stack will allow users to use package-based, integrated, or standalone workspace types.

Before:

npx -y create-nx-workspace

 >  NX   Let's create a new workspace [https://nx.dev/getting-started/intro]

✔ Where would you like to create your workspace? · org6
? Which stack do you want to use? …
None:          Configures a minimal structure without specific frameworks or technologies.
TS/JS:         Configures a TypeScript/JavaScript package without specific frameworks or platforms.
React:         Configures a React app with your framework of choice.
Angular:       Configures a Angular app with modern tooling.
Node:          Configures a Node API with your framework of choice.

After (stack):

npx -y create-nx-workspace

 >  NX   Let's create a new workspace [https://nx.dev/getting-started/intro]

✔ Where would you like to create your workspace? · org6
? Which stack do you want to use? …
None:          Configures a TypeScript/JavaScript project with minimal structure.
React:         Configures a React application with your framework of choice.
Angular:       Configures a Angular application with modern tooling.
Node:          Configures a Node API application with your framework of choice.

After (workspace type):

? Package-based monorepo, integrated monorepo, or standalone project? …
Package-based Monorepo:     Nx makes it fast, but lets you run things your way.
Integrated Monorepo:        Nx creates a monorepo that contains multiple projects.
Standalone:                 Nx creates a single project and makes it fast.

Video explainer:

ts-presets.mp4

@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 6:45pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 13, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c41ffb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

interface TsArguments extends BaseArguments {
stack: 'ts';
workspaceType: 'standalone' | 'integrated';
workspaceType: 'package-based' | 'integrated' | 'standalone' | 'integrated';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 integrated here.

What is the difference between package-based and integrated?

  • package-based has packages directory while integrated has libs?
  • package-based has package.json projects while integrated has project.json` ?
  • package-based projects do not use executors while integrated do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, integrated is currently apps-libs, and packaged-based uses packages and does not use our executors. We'd be missing an option for monorepo with packages and use executors, but it's covered by the --preset=ts option that we've support for quite some time (as seen in the tutorial https://nx.dev/getting-started/tutorials/integrated-repo-tutorial).

@FrozenPandaz FrozenPandaz merged commit 0040520 into nrwl:master Jul 18, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants