-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): merge None and TS stacks into one since they are both for TS/JS projects #18108
feat(core): merge None and TS stacks into one since they are both for TS/JS projects #18108
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1c41ffb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
311955f
to
c6d470c
Compare
interface TsArguments extends BaseArguments { | ||
stack: 'ts'; | ||
workspaceType: 'standalone' | 'integrated'; | ||
workspaceType: 'package-based' | 'integrated' | 'standalone' | 'integrated'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 integrated here.
What is the difference between package-based
and integrated
?
package-based
haspackages
directory whileintegrated
haslibs
?package-based
haspackage.json
projects whileintegrated has
project.json` ?package-based
projects do not use executors whileintegrated
do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, integrated is currently apps-libs, and packaged-based uses packages
and does not use our executors. We'd be missing an option for monorepo with packages
and use executors, but it's covered by the --preset=ts
option that we've support for quite some time (as seen in the tutorial https://nx.dev/getting-started/tutorials/integrated-repo-tutorial).
c6d470c
to
d076870
Compare
d076870
to
1c41ffb
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR combines the TS stack into None. The merged stack will allow users to use package-based, integrated, or standalone workspace types.
Before:
After (stack):
After (workspace type):
Video explainer:
ts-presets.mp4