Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): timeout after 20 min waiting for remote #18099

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

koenvangeert
Copy link
Contributor

Current Behavior

When using module federation the server will close after 20 minutes with the following error:

.../node_modules/@nx/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.js:98
                throw new Error(`Timed out waiting for remote to start. Check above for any errors.`);
                      ^

Error: Timed out waiting for remote to start. Check above for any errors.
    at .../node_modules/@nx/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.js:98:23
    at Generator.throw (<anonymous>)
    at rejected (.../node_modules/tslib/tslib.js:165:69)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Expected Behavior

The server keeps on running

Cause

The following pr caused the bug to occur: #17192
The webpack dev server doesn't bind to 127.0.0.1 by default.
It only binds to localhost and ::1.

Related Issue(s)

Fixes #17354

@koenvangeert koenvangeert requested a review from a team as a code owner July 13, 2023 09:11
@koenvangeert koenvangeert requested a review from xiongemi July 13, 2023 09:11
@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 1:56pm

@xiongemi
Copy link
Collaborator

thanks for submitting this pr. i think host: 'localhost' was already removed. i am going to close this pr.

@vadimka123
Copy link
Contributor

@xiongemi , removing host: 'localhost' cause issue
Returning back will fix this bug
I manually fixing every time now by updating relevant file in my local node_modules with this change
But I want to have merged this change ASAP

@Coly010 Coly010 reopened this Jul 26, 2023
@Coly010
Copy link
Contributor

Coly010 commented Jul 26, 2023

Let me take a look at this :)

@Coly010 Coly010 self-requested a review July 26, 2023 08:33
@Coly010 Coly010 enabled auto-merge (squash) July 27, 2023 13:19
@Coly010 Coly010 merged commit 01ef42b into nrwl:master Jul 27, 2023
@DheerajMahra
Copy link

Hi team, please mentioned the release into which this issue is fixed

@DheerajMahra
Copy link

DheerajMahra commented Jul 28, 2023

Ok, the fix is listed in 16.6.0 pre-release - https://github.com/nrwl/nx/releases/tag/16.6.0-beta.6

When are you planning to release the stable 16.6.0?

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React, MFE - Timed out waiting for remote to start. Check above for any errors
6 participants