Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix project configuration typings #18073

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

  1. Hashing of the project configurations is not deterministic which means changes that should be applied incrementally are not always applied incrementally.
  2. When changes are applied incrementally, the typings are wrong and cause errors.

Expected Behavior

  1. Hashing of the project configurations is deterministic.
  2. When changes are applied incrementally, the typings are correct and do not cause errors.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner July 11, 2023 15:06
@FrozenPandaz FrozenPandaz requested a review from vsavkin July 11, 2023 15:06
@vercel
Copy link

vercel bot commented Jul 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 4:20pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b312b3c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants