Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle undefined target defaults #18044

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jul 10, 2023

Current Behavior

Some commands (e.g. nx graph) fail when targetDefaults is not defined in nx.json.

Expected Behavior

The targetDefaults option in nx.json is optional and should be handled correctly when not defined.

Related Issue(s)

Fixes #18038

@leosvelperez leosvelperez self-assigned this Jul 10, 2023
@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 8:14am

@nx-cloud
Copy link

nx-cloud bot commented Jul 10, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a943fc6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez marked this pull request as ready for review July 10, 2023 08:14
@leosvelperez leosvelperez requested a review from a team as a code owner July 10, 2023 08:14
@leosvelperez leosvelperez requested a review from vsavkin July 10, 2023 08:14
@AgentEnder AgentEnder merged commit 92926b9 into nrwl:master Jul 10, 2023
@leosvelperez leosvelperez deleted the core/handle-undefined-target-defaults branch July 10, 2023 14:45
FrozenPandaz pushed a commit that referenced this pull request Jul 10, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx task graph crashes if no target defaults are configured in nx.json
2 participants