Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): properly identify file as story #18016

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

mandarini
Copy link
Member

closed #17965

Current Behavior

import type { Meta } from '@storybook/react'; is not recognized as a Story import.

Expected Behavior

import type { Meta } from '@storybook/react'; should be recognized as a Story import. No need to import {Story} any more, Meta suffices.

Related Issue(s)

Fixes #17965

@mandarini mandarini requested a review from a team as a code owner July 7, 2023 08:07
@mandarini mandarini requested a review from Coly010 July 7, 2023 08:07
@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 8:10am

@mandarini mandarini self-assigned this Jul 7, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 7, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6e48518. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mandarini mandarini merged commit 21007d8 into nrwl:master Jul 7, 2023
@mandarini mandarini deleted the fix/storybook-story-identifier branch July 7, 2023 14:52
FrozenPandaz pushed a commit that referenced this pull request Jul 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/react:stories generates index.stories.stories.tsx for some files
2 participants