Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): pin Vite version range to patch releases only to avoid conflicts with Angular #18010

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jul 6, 2023

This PR changes the version range for Vite packages to only include patch releases. Updating to latest minor may cause breakage if Angular devkit is still using the previous minor.

If you run pnpm why vite for the failing workspace you'll see this:

      @nx/angular 17.0.0
      └─┬ @angular-devkit/build-angular 16.1.4 peer
        ├─┬ @vitejs/plugin-basic-ssl 1.0.1
        │ └── vite 4.3.9 peer
        └── vite 4.3.9
      @nx/vite 17.0.0
      ├── vite 4.3.9 peer
      └─┬ vitest 0.32.0 peer
        ├── vite 4.4.1
        └─┬ vite-node 0.32.0
          └── vite 4.4.1
      @vitejs/plugin-react 4.0.0
      └── vite 4.3.9 peer
      @vitest/coverage-c8 0.32.0
      └─┬ vitest 0.32.0 peer
        ├── vite 4.4.1
        └─┬ vite-node 0.32.0
          └── vite 4.4.1
      @vitest/ui 0.32.0
      └─┬ vitest 0.32.0 peer
        ├── vite 4.4.1
        └─┬ vite-node 0.32.0
          └── vite 4.4.1
      vite 4.3.9
      vite-plugin-dts 2.3.0
      └── vite 4.3.9 peer
      vite-tsconfig-paths 4.2.0
      └── vite 4.3.9 peer
      vitest 0.32.0
      ├── vite 4.4.1
      └─┬ vite-node 0.32.0
        └── vite 4.4.1

Current Behavior

e2e tests are failing (e.g. https://staging.nx.app/runs/RvNeUFFbhV)

Expected Behavior

e2e tests should pass

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 3:16am

@jaysoo jaysoo marked this pull request as ready for review July 6, 2023 20:10
@jaysoo jaysoo requested review from a team as code owners July 6, 2023 20:10
@jaysoo jaysoo requested a review from mandarini July 6, 2023 20:10
@nx-cloud
Copy link

nx-cloud bot commented Jul 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9704a4e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jaysoo jaysoo force-pushed the feat/pin-vite-to-minor-versions branch from 62074e8 to 50f280c Compare July 7, 2023 00:52
@jaysoo jaysoo force-pushed the feat/pin-vite-to-minor-versions branch from 50f280c to 3627501 Compare July 7, 2023 03:10
@mandarini mandarini merged commit 3fdc66d into nrwl:master Jul 7, 2023
FrozenPandaz pushed a commit that referenced this pull request Jul 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants