fix(core): parse project configs only in js #18009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 159f749. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Cammisuli
requested changes
Jul 6, 2023
FrozenPandaz
force-pushed
the
fix-project-configs
branch
from
eb8e908 to
178a461
Compare
FrozenPandaz
force-pushed
the
fix-project-configs
branch
from
178a461 to
1e5238d
Compare
Cammisuli
requested changes
Jul 7, 2023
FrozenPandaz
force-pushed
the
fix-project-configs
branch
from
1e5238d to
8958f39
Compare
FrozenPandaz
force-pushed
the
fix-project-configs
branch
from
8958f39 to
bc56966
Compare
FrozenPandaz
force-pushed
the
fix-project-configs
branch
from
bc56966 to
159f749
Compare
Cammisuli
approved these changes
Jul 7, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx parses config files in Rust.. and then reparses it in JS and sometimes assigns the project a different name.
Expected Behavior
Nx only identifies project config files in rust.. but only parses the file in JS and always assigns the project the same name. The project file map is calculated in JS from the parsed project configs.
Related Issue(s)
Fixes #