Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): optional chain .length in utils #18001

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

Cannot read properties of undefined (reading 'length')

Expected Behavior

Should just skip if array is undefined.

Related Issue(s)

Fixes #17966

@mandarini mandarini self-assigned this Jul 6, 2023
@mandarini mandarini requested a review from a team as a code owner July 6, 2023 15:50
@mandarini mandarini requested a review from jaysoo July 6, 2023 15:50
@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 7:58am

@mandarini mandarini enabled auto-merge (squash) July 6, 2023 15:52
@nx-cloud
Copy link

nx-cloud bot commented Jul 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab46439. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mandarini mandarini force-pushed the fix/storybook-length-issue branch from 33c3550 to ab46439 Compare July 7, 2023 07:55
@mandarini mandarini merged commit 3edbe49 into nrwl:master Jul 7, 2023
@mandarini mandarini deleted the fix/storybook-length-issue branch July 7, 2023 14:52
FrozenPandaz pushed a commit that referenced this pull request Jul 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue while migrating storybook from v16.4.3 to v16.5.0
2 participants