Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.5.0 does not work on Node.js 14 anymore #17986

Closed
1 of 4 tasks
danez opened this issue Jul 6, 2023 · 3 comments · Fixed by #18043
Closed
1 of 4 tasks

16.5.0 does not work on Node.js 14 anymore #17986

danez opened this issue Jul 6, 2023 · 3 comments · Fixed by #18043

Comments

@danez
Copy link

danez commented Jul 6, 2023

Current Behavior

$ ./node_modules/.bin/nx run-many --target=build --exclude='@react-docgen-internal/*' --verbose

 >  NX   Running target build for 2 projects:

    - @react-docgen/cli
    - react-docgen

 ———————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 ———————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Successfully ran target build for 2 projects



 >  NX   performance is not defined


ReferenceError: performance is not defined
    at Cache.<anonymous> (/workspace/react-docgen/node_modules/.pnpm/[email protected]/node_modules/nx/src/tasks-runner/cache.js:124:13)
    at Generator.next (<anonymous>)
    at /workspace/react-docgen/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:169:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/workspace/react-docgen/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:165:16)
    at Cache._expandOutputs (/workspace/react-docgen/node_modules/.pnpm/[email protected]/node_modules/nx/src/tasks-runner/cache.js:122:24)
    at Cache.<anonymous> (/workspace/react-docgen/node_modules/.pnpm/[email protected]/node_modules/nx/src/tasks-runner/cache.js:118:25)
    at Generator.next (<anonymous>)
    at /workspace/react-docgen/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:169:75
    at new Promise (<anonymous>)

Expected Behavior

To work normally as in 16.4.x

GitHub Repo

reactjs/react-docgen#817

Steps to Reproduce

  1. clone
  2. nvm install 14
  3. pnpm run build

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 14.21.3
   OS     : linux-x64
   pnpm   : 8.6.6
   
   nx          : 16.5.0
   @nrwl/tao   : 16.5.0
   typescript  : 5.1.6

Failure Logs

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@danez danez added the type: bug label Jul 6, 2023
@tido64
Copy link

tido64 commented Jul 7, 2023

We are also hitting the same issue. We maintain a bunch of tools that still support v14, so we still run v14 on CI.

@chigia001
Copy link
Contributor

This is introduce by #17638
Node@14 don't support the performance global object.
CC: @Cammisuli

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants