feat(testing): add @nx/playwright plugin #17975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
2 times, most recently
from
fb185d1 to
51ac6b1
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3a3115e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
3 times, most recently
from
6fee2c0 to
c11b9d7
Compare
barbados-clemens
commented
Jul 6, 2023
barbados-clemens
added
the
scope: testing tools
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
c11b9d7 to
829454e
Compare
barbados-clemens
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder,
meeroslav,
mandarini,
jaysoo and
JamesHenry
as code owners
mandarini
approved these changes
Jul 6, 2023
|
Nice!!!! :D |
xiongemi
reviewed
Jul 6, 2023
xiongemi
reviewed
Jul 6, 2023
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
625214c to
22a5ea0
Compare
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
22a5ea0 to
f8191a8
Compare
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
f8191a8 to
f545973
Compare
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
f545973 to
57f10c1
Compare
jaysoo
approved these changes
Jul 7, 2023
FrozenPandaz
requested changes
Jul 7, 2023
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
57f10c1 to
3700fbb
Compare
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
3700fbb to
afb196f
Compare
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
afb196f to
6cee1e2
Compare
barbados-clemens
force-pushed
the
feat/playwrite-plugin
branch
from
6cee1e2 to
3a3115e
Compare
AgentEnder
approved these changes
Jul 11, 2023
FrozenPandaz
approved these changes
Jul 11, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
no first party playwright plugin for nx.
Expected Behavior
@nx/playwright plugin
Related Issue(s)
Note:
assumed generator setup
playwright.config.ts in the project root with testDir set from the project root, and reporter options set to output in the top level 'dist/playwright/', only tested with html reporter.
I didn't look into what the eslint settings would look like nor tsconfig settings.
Might be able to take inspo from nxkit playwright plugin