Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): add license information for native packages #17964

Merged

Conversation

vergilfromadyen
Copy link
Contributor

@vergilfromadyen vergilfromadyen commented Jul 5, 2023

Current Behavior

Native packages don't contain license information package.json

Expected Behavior

Native packages contain license information in package.json

Related Issue(s)

Fixes #17963

@vergilfromadyen vergilfromadyen requested a review from a team as a code owner July 5, 2023 12:22
@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 1:19pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 5, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9f6b651. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@zacowan
Copy link

zacowan commented Jul 5, 2023

Was about to raise this as well - thanks 😄

@FrozenPandaz
Copy link
Collaborator

Good catch! Thank you for fixing it. LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit d42d2f4 into nrwl:master Jul 5, 2023
@vergilfromadyen vergilfromadyen deleted the add-license-info-to-native-pkgs branch July 5, 2023 15:06
FrozenPandaz pushed a commit that referenced this pull request Jul 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing license information for native packages
3 participants