fix(js): ignore dependencies from non-index root files for create-package-json #17930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1d65ee5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
meeroslav
added
scope: core
meeroslav
changed the title
LayZeeDK
reviewed
Jul 4, 2023
meeroslav
force-pushed
the
fix-create-package-json-non-prod
branch
from
64618b0 to
6596799
Compare
FrozenPandaz
requested changes
Jul 5, 2023
FrozenPandaz
approved these changes
Jul 5, 2023
AgentEnder
approved these changes
Jul 5, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The package json generation (and
dependency checkslinter rule) reads all theproductionfiles' dependencies, including files relevant only at the compile time - vite.config.ts, webpack.config.js etc. which includes dev packages in the resulting package.jsonExpected Behavior
Only non-dev dependencies should be taken into account when constructing dependencies list if
isProductionis set.Related Issue(s)
Fixes #17905