Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add support for TS Module Federation Config #15739 #17876

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jun 30, 2023

Current Behavior

We do not support TS Config for Module Federation Config

Expected Behavior

We should support TS for the Module Federation Config

Related Issue(s)

Fixes #15739

@Coly010 Coly010 requested review from a team as code owners June 30, 2023 09:04
@Coly010 Coly010 requested a review from ndcunningham June 30, 2023 09:04
@Coly010 Coly010 self-assigned this Jun 30, 2023
@Coly010 Coly010 requested a review from jaysoo June 30, 2023 09:04
@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 9:26am

@nx-cloud
Copy link

nx-cloud bot commented Jun 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 187bd5a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Coly010 Coly010 force-pushed the module-federation-ts branch 2 times, most recently from f539e6b to a81f361 Compare June 30, 2023 09:20
@Coly010 Coly010 merged commit 77bb4b7 into nrwl:master Jul 12, 2023
@Coly010 Coly010 deleted the module-federation-ts branch July 12, 2023 15:14
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement custom module federation config path in angular/src/builders/utilities/module-federation.ts
2 participants