Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): pin @yarnpkg/parsers version to avoid dropping support for node.js v16 #17860

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jun 29, 2023

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #17857

@leosvelperez leosvelperez self-assigned this Jun 29, 2023
@leosvelperez leosvelperez requested review from a team as code owners June 29, 2023 13:47
@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 1:51pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bef1b1a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@arcanis
Copy link

arcanis commented Jul 3, 2023

Shouldn't you cherry-pick it in at least a patch release? We released a new RC and it breaks nx / Lerna again; I can publish another workaround, but I'd prefer to not have to do that for every release we publish.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX does not work on node <18 due to @yarnpkg/parsers version
3 participants