fix(core): cli option --graph should work with scoped package names #17820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c763285. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/graph-with-scoped-package-names
branch
from
dd2fa4e to
96464b2
Compare
AgentEnder
force-pushed
the
fix/graph-with-scoped-package-names
branch
from
96464b2 to
c763285
Compare
FrozenPandaz
approved these changes
Jun 27, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running
nx build @scoped/package --graphfails. This is because we use the URL class when building up our URL, but also manually invoke encodeURIComponent on the project names. We don't need to manually encode the URL, as the URL class handles that.This results in the
@and/characters being encoded once by us, and then the%signs being encoded by the URL class which results in an invalid URLExpected Behavior
Running
nx build @scoped/package --graphworksRelated Issue(s)
Fixes #