Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): add --force-exit to jest executor #17790

Merged

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Jun 26, 2023

Current Behavior

--force-exit isn't an executor option for jest, but is an arg for the jest cli

Expected Behavior

--force-exit is an option for jest executor

Related Issue(s)

Fixes #17574

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:03pm

@barbados-clemens barbados-clemens self-assigned this Jun 26, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jun 26, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jun 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3acb98b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@barbados-clemens barbados-clemens force-pushed the feat/add-force-exit-jest-option branch from 0f190c4 to 3acb98b Compare June 26, 2023 14:59
@barbados-clemens barbados-clemens removed request for a team and ndcunningham June 26, 2023 15:00
Copy link
Contributor Author

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branched off wrong base so added webpack changes. reverted those. Sorry for the extra review tags.

@barbados-clemens barbados-clemens merged commit 836cd34 into nrwl:master Jun 26, 2023
@barbados-clemens barbados-clemens deleted the feat/add-force-exit-jest-option branch June 26, 2023 22:06
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest - Add "forceExit" option
2 participants