fix(js): fix yarn setup to work with yarn3 #17716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a7ad5b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fahslaj
approved these changes
Jun 21, 2023
AgentEnder
requested changes
Jun 21, 2023
| } catch (e) { | ||
| return () => {}; | ||
| } | ||
| const yarnV1 = major(execSync('yarn --version').toString().trim()) === 1; |
There was a problem hiding this comment.
Can we call this isYarnV1 instead or something similar?
|
|
||
| if (!yarnV1) { | ||
| execSync( | ||
| `yarn config set unsafeHttpWhitelist --json '["localhost"]'` + |
There was a problem hiding this comment.
This will overwrite the existing value and we don't have a stored value to set it back to, potentially breaking folks.
| : '' | ||
| ); | ||
| logger.info( | ||
| `Whitelist http://localhost:${options.port}/ as an unsafe http server` |
There was a problem hiding this comment.
Suggested change
| `Whitelist http://localhost:${options.port}/ as an unsafe http server` | |
| `Whitelisted http://localhost:${options.port}/ as an unsafe http server` |
FrozenPandaz
force-pushed
the
yarn3-support
branch
from
c39b9f4 to
0102739
Compare
FrozenPandaz
force-pushed
the
yarn3-support
branch
from
0102739 to
a7ad5b4
Compare
FrozenPandaz
changed the title
xiongemi
approved these changes
Jun 22, 2023
AgentEnder
approved these changes
Jun 22, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
An error is thrown if using the
verdaccioexecutor with yarn 3Expected Behavior
The verdaccio executor works with yarn 3
Related Issue(s)
Fixes #