Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): get the client env when calculating the task hash in the daemon #17677

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

Cammisuli
Copy link
Member

Current Behavior

When the daemon is running, getting the env for tasks with an env input does not get the environment from where the command is run. Because the daemon is in a different process, it always gets the same env when it was first booted up with

Expected Behavior

When asking the daemon to hash a task, the client will send the current client env so that the daemon gets information relative to the client

Related Issue(s)

Fixes #17633

@Cammisuli Cammisuli requested a review from a team as a code owner June 19, 2023 17:53
@Cammisuli Cammisuli requested a review from vsavkin June 19, 2023 17:53
@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 11:22am

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env input is ignored since 16.3.0
2 participants