Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prune project graph after affected nodes are found to avoid errors #17675

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jun 19, 2023

We prune external nodes from project graph when outputting JSON so it doesn't get too bloated. However, this erroring out when finding affected nodes since affected logic requires external nodes to be present.

Current Behavior

nx graph --affected errors out

Expected Behavior

nx graph --affected works as expected

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner June 19, 2023 17:00
@jaysoo jaysoo requested a review from FrozenPandaz June 19, 2023 17:00
@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 6:13pm

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants