-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): run-commands should not parse strings as numbers #17670
Merged
FrozenPandaz
merged 1 commit into
nrwl:master
from
Coly010:core/fix-run-commands-args-parsing
Jun 20, 2023
Merged
fix(core): run-commands should not parse strings as numbers #17670
FrozenPandaz
merged 1 commit into
nrwl:master
from
Coly010:core/fix-run-commands-args-parsing
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested changes
Jun 19, 2023
Coly010
force-pushed
the
core/fix-run-commands-args-parsing
branch
from
June 19, 2023 14:45
8608927
to
dd83095
Compare
FrozenPandaz
approved these changes
Jun 20, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When passing command line args to a target using nx:run-commands whose value resembles a number, it is being parsed as a number.
This can cause erroneous behaviour when the intention of the value is to be a string.
The main potential of erroneous behaviour here comes from decimal numbers ending in 0, such as
1234.10
. When this is parsed as a number then converted back to a string for interpolation, this value becomes1234.1
.Expected Behavior
Args that are passed to the nx:run-commands via command line should not be parsed as numbers.
We should leave support args that are passed as options in the project.json
Related Issue(s)
Fixes #17575