feat(nx-plugin): update e2e tests to use local-registry and be simpler #17639
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ecff9ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| @@ -26,4 +22,7 @@ packages: | |||
| logs: | |||
| type: stdout | |||
| format: pretty | |||
| level: http | |||
| level: warn | |||
There was a problem hiding this comment.
@xiongemi I could not get these tests to work unless I brought this down to warn... Do you have any idea why?
| { | ||
| cwd: dirname(projectDirectory), | ||
| stdio: 'inherit', | ||
| env: process.env, |
There was a problem hiding this comment.
Note: The default is process.env, so it's not necessary unless we're adding more values to it.
There was a problem hiding this comment.
Let me try without it in another PR.
I know it shouldn't make any difference... but somehow it does sometimes?
| host, | ||
| options.pluginName | ||
| ); | ||
| const { name: pluginPackageName } = readJson( |
There was a problem hiding this comment.
Do we care if pluginPackageName is undefined? It is required in package.json so we could it's always there, otherwise it's a user error. We can also validate it and error out if it's missing somehow.
There was a problem hiding this comment.
I'll add this in a follow up.
|
Left some comments, LGTM overall |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
e2e tests use special utils from
@nx/pluginwhich obfuscate what the tests doExpected Behavior
e2e tests Node APIs which allow users to easily determine what's going on
Related Issue(s)
Fixes #