Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ignore nested node_module paths for findProjectOfResolvedModule in TargetProjectLocator #17630

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

TargetProjectLocator's findProjectOfResolvedModule will treat unknown imports as the source project if import is pointing to nested node_modules.

Expected Behavior

The findProjectOfResolvedModule should check if module path contains node_modules (not only if it starts with one)

Related Issue(s)

Fixes #15957

@meeroslav meeroslav self-assigned this Jun 16, 2023
@meeroslav meeroslav requested a review from a team as a code owner June 16, 2023 13:15
@meeroslav meeroslav requested a review from Cammisuli June 16, 2023 13:15
@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 1:19pm

@meeroslav meeroslav merged commit 1fda800 into nrwl:master Jun 18, 2023
meeroslav added a commit to ericyd/nx that referenced this pull request Jun 23, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eslint rule enforce-module-boundaries false positive
2 participants