feat(nx-plugin): add verdaccio to create package e2e #17566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
1f92aa2 to
218cd71
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
218cd71 to
8fcc022
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
8fcc022 to
a7b1e13
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
a7b1e13 to
c773dc0
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
c773dc0 to
2880d9a
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
2 times, most recently
from
2252ad5 to
351d3f1
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
351d3f1 to
f5f710a
Compare
mandarini
approved these changes
Jun 14, 2023
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
f5f710a to
f629267
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
f629267 to
96ad057
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
96ad057 to
088263f
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
088263f to
b4540c6
Compare
barbados-clemens
approved these changes
Jun 15, 2023
FrozenPandaz
requested changes
Jun 15, 2023
packages/plugin/src/generators/create-package/create-package.ts
Outdated
Show resolved
Hide resolved
packages/plugin/src/generators/create-package/files/e2e/__cliName__.spec.ts__tmpl__
Outdated
Show resolved
Hide resolved
packages/plugin/src/generators/create-package/files/e2e/__cliName__.spec.ts__tmpl__
Outdated
Show resolved
Hide resolved
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
b4540c6 to
4b9faba
Compare
xiongemi
force-pushed
the
feat/add-verdaccio-plugin-e2e-tests
branch
from
4b9faba to
5080a9b
Compare
FrozenPandaz
approved these changes
Jun 16, 2023
| rootProject: false, | ||
| }); | ||
|
|
||
| function addE2eProject(host: Tree, options: NormalizedSchema) { |
There was a problem hiding this comment.
followup: this function name isn't accurate anymore, no project is added.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #