fix(misc): mark name as required for ci-workflow generator #17551
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 51cdbad. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
MaxKless
force-pushed
the
ci-worksflow-important
branch
from
cc515bb to
277bbd5
Compare
| @@ -31,7 +31,8 @@ | |||
| }, | |||
| "default": "CI", | |||
| "x-prompt": "How should we name your workflow?", | |||
| "pattern": "^[a-zA-Z].*$" | |||
| "pattern": "^[a-zA-Z].*$", | |||
| "x-priority": "important" | |||
There was a problem hiding this comment.
pedantic: I think it should be required. I'm surprised it isn't marked as required. We should opt for that instead of using x-priority.
There was a problem hiding this comment.
There's a default value of CI that's used when you don't provide a name... I guess we could remove that and make name required but then again sometimes folks might want to create a workflow and don't care what it's called.
FrozenPandaz
changed the title
MaxKless
changed the title
MaxKless
force-pushed
the
ci-worksflow-important
branch
from
277bbd5 to
eb48fe0
Compare
MaxKless
force-pushed
the
ci-worksflow-important
branch
from
eb48fe0 to
dff1177
Compare
MaxKless
force-pushed
the
ci-worksflow-important
branch
from
dff1177 to
51cdbad
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
In Nx Console, it looks weird if you have to expand all options when there's only two overall and there's no reason to not see both at the same time.