feat(linter): allow globs in onlyDependOnLibsWithTags eslint-plugin configuration option #17530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e297d72. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ericyd
commented
Jun 9, 2023
Comment on lines
106
to
110
| // if the tag is a glob, check if the project matches the glob prefix | ||
| if (tag.endsWith('*')) { | ||
| const prefix = tag.substring(0, tag.length - 1); | ||
| return (proj.data.tags || []).some((t) => t.startsWith(prefix)); | ||
| } |
There was a problem hiding this comment.
I know this is a pretty naïve implementation of glob support, but since this option already supports regex I figured it didn't really need to be ultra robust. Happy to revisit if desired
meeroslav
requested review from
jaysoo,
AgentEnder,
a team,
isaacplmann,
meeroslav,
vsavkin,
mandarini,
leosvelperez,
StalkAltan,
rarmatei and
JamesHenry
as code owners
meeroslav
requested review from
a team
and removed request for
a team,
vsavkin,
jaysoo,
isaacplmann,
JamesHenry,
rarmatei,
StalkAltan,
mandarini,
AgentEnder and
leosvelperez
…onfiguration option add support for globs (in addition to existing string, regex, and * options) to the onlyDependOnLibsWithTags configuration option for the eslint-plugin closed nrwl#15264
meeroslav
force-pushed
the
ericyd/add-glob-support-to-eslint-plugin-onlyDependOnLibsWithTags-option
branch
from
6103878 to
e297d72
Compare
meeroslav
approved these changes
Jun 30, 2023
meeroslav
added
type: feature
scope: linter
isaacplmann
approved these changes
Jun 30, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
onlyDependOnLibsWithTagsdoes not handle glob patterns in the tags list. However, several other options for theeslint-plugindo support glob patterns.Expected Behavior
Update
onlyDependOnLibsWithTagsto handle glob patterns in tag lists. This allows a tagged package to depend on any packages matching the glob, rather than only specific tags.Note: this behavior was already available, via Regex support. However, the ability to use regular expressions in the tag list was undocumented. This PR adds documentation for the new glob pattern as well as the existing regex pattern.
Related Issue(s)
Fixes #15264
Questions to maintainers
pnpm iand it added 10k+ files to a.pnpm-storedirectory. Should this directory be added to.gitignore? This didn't happen when I ranpnpm installoutside of the devcontainer, so I'm not clear where the discrepancy comes from