fix(react): mf remote name incorrect with directory option

[victoriahu]

Current Behavior

When a developer generates a remote via CLI and passes in a directory (e.g. ▶ yarn nx generate @nrwl/react:remote --name=test --host=host-name --directory=apps/host-name/applications), the remote uses the project name, while the host does not use the project name.

Then the developer must take the following steps to run their host without error:

• Change their remote name in apps/host-name/src/remotes.d.ts.

declare module "test/Module"; >> declare module "host-name-applications-test/Module";

• Change their remote name in apps/host-name/module-federation.config.ts.

const moduleFederationConfig = {
  ...baseConfig,
  name: "host-name",
  remotes: [
    ... other remotes,
    // "," --> delete this line
    // change from this --> "test", to the below:
    "host-name-applications-test",
  ],
  additionalShared: [
    ...baseConfig.additionalShared,
  ],
};

This is because Nx uses the directory to prepend the project name, and passing in options.name to the host does not prepend the directory. Therefore passing in a directory to the CLI will mean that the parameter passed in to the updateHostWithRemote method will always be incorrect.

Expected Behavior

When a developer generates a remote via CLI and passes in a directory, the remote and the host both use the project name. There is no need to update either the remotes.d.ts or module-federation.config.ts files.

Related Issue(s)

#16308

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2023 10:32pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b39a522. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --base= --head=
• nx affected --target=e2e --base=ed0136b1219aa66d327d1d9c4905786d0c1d920f --head=b39a522a0ab3d05194667b1dde7443f10e66a05a --parallel=1
• nx affected --target=test --base=ed0136b1219aa66d327d1d9c4905786d0c1d920f --head=b39a522a0ab3d05194667b1dde7443f10e66a05a --parallel=1
• nx affected --target=build --base=ed0136b1219aa66d327d1d9c4905786d0c1d920f --head=b39a522a0ab3d05194667b1dde7443f10e66a05a --parallel=3
• nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners --parallel=1 --no-dte
• nx affected --target=lint --base=ed0136b1219aa66d327d1d9c4905786d0c1d920f --head=b39a522a0ab3d05194667b1dde7443f10e66a05a --parallel=3
• nx-cloud record -- nx format:check --base=ed0136b1219aa66d327d1d9c4905786d0c1d920f --head=b39a522a0ab3d05194667b1dde7443f10e66a05a
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.