Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix pnpm lockfile parsing in v6.1 #17407

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix(core): fix pnpm lockfile parsing in v6.1 #17407

merged 1 commit into from
Jun 7, 2023

Conversation

jojoa
Copy link
Contributor

@jojoa jojoa commented Jun 3, 2023

Fix the Version check in the pnpm lockfile parsing process from v6.0 to v6.x, as done in the pnpm source, to fix a error in the generatePackageJson Plugin to not find the deps

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Fix the Version check in the pnpm lockfile parsing process from v6.0 to v6.x, as done in the pnpm
source, to fix a error in the generatePackageJson Plugin to not find the deps
@jojoa jojoa requested review from a team and meeroslav as code owners June 3, 2023 22:02
@jojoa jojoa requested a review from vsavkin June 3, 2023 22:02
@vercel
Copy link

vercel bot commented Jun 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2023 10:05pm

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@meeroslav meeroslav merged commit 05fb178 into nrwl:master Jun 7, 2023
juristr pushed a commit to juristr/nx that referenced this pull request Jun 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants