Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): resolve full paths to vite configs for vitest #17396

Merged

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Jun 2, 2023

Current Behavior

vite/vitest could infer invalid paths for configs with custom config files

Expected Behavior

vite uses the correct config file when passed in

Related Issue(s)

Fixes #16985
TODO:

  • test on windows

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 7:57pm

@barbados-clemens barbados-clemens self-assigned this Jun 2, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jun 2, 2023
@barbados-clemens barbados-clemens marked this pull request as ready for review June 2, 2023 19:53
@barbados-clemens barbados-clemens requested a review from a team as a code owner June 2, 2023 19:53
@barbados-clemens barbados-clemens merged commit ca38a23 into nrwl:master Jun 2, 2023
@barbados-clemens barbados-clemens deleted the fix/vitest-custom-config branch June 2, 2023 21:32
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/vite:test impossible to use a custom config file located inside a project root
2 participants