fix(node): When serving using js:node executor NODE_ENV should not be undefined #17375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
force-pushed
the
fix/js-node-env-undefined
branch
from
7ea09f5 to
abb39ac
Compare
nartc
approved these changes
Jun 1, 2023
… undefined closes: nrwl#16960
ndcunningham
force-pushed
the
fix/js-node-env-undefined
branch
from
abb39ac to
8cfbdd0
Compare
barbados-clemens
approved these changes
Jun 1, 2023
AgentEnder
previously requested changes
Jun 1, 2023
| @@ -36,6 +36,7 @@ export async function* nodeExecutor( | |||
| options: NodeExecutorOptions, | |||
| context: ExecutorContext | |||
| ) { | |||
| process.env.NODE_ENV ??= context?.configurationName ?? 'development'; | |||
There was a problem hiding this comment.
Should these both default to the same value? Currently esbuild defaults to production and this hits dev
There was a problem hiding this comment.
This is serve, I don't think we default it to production right?
FrozenPandaz
dismissed
AgentEnder’s stale review
These should not be the same value.
FrozenPandaz
approved these changes
Jun 2, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #16960