fix(angular): loosen package updates requirements #17317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
angular/relax-migration-requirements
branch
from
08b1b44 to
e751939
Compare
Coly010
approved these changes
May 31, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Migrating an Nx workspace with Angular with multiple package updates for Typescript collected causes the Angular package updates to not be collected.
Expected Behavior
Migrating an Nx workspace with Angular should work correctly.
Note: removing the Typescript requirement solves the issue and doesn't cause any additional issues. The requirement was too restrictive and provided very little benefit. It was a small layer of protection for folks running in interactive mode, but when running in interactive mode, you're opting out of the Nx-managed automatic updates which means that you're in control and you need to know what you're doing when it comes to dependencies.
Related Issue(s)
Fixes #17100