Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): set node_env when building with esbuild #17251

Merged
merged 1 commit into from
May 29, 2023

Conversation

ndcunningham
Copy link
Contributor

closes: #16960

@ndcunningham ndcunningham self-assigned this May 26, 2023
@ndcunningham ndcunningham requested review from a team as code owners May 26, 2023 19:29
@ndcunningham ndcunningham requested review from jaysoo and juristr May 26, 2023 19:29
@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 2:29pm

@ndcunningham ndcunningham merged commit 923e6d8 into nrwl:master May 29, 2023
@ndcunningham ndcunningham deleted the fix/node-env-undefined branch June 1, 2023 17:15
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NODE_ENV is undefined
3 participants