Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): allow root js lib project to be generated #17245

Merged
merged 1 commit into from
May 26, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 26, 2023

The rootProject: true option for @nx/js:lib doesn't actually work. Main two problems are:

  1. tsconfig.base.json is still generated even if no other projects are present to require it.
  2. nx build will fail if @nx/js:swc is used because it doesn't work when the project is at the root ..
  3. Choosing bundler that isn't esbuild or rollup did not install @types/node package, which is required to build libs.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 3:40pm

@jaysoo jaysoo marked this pull request as ready for review May 26, 2023 14:46
@jaysoo jaysoo requested a review from a team as a code owner May 26, 2023 14:46
@jaysoo jaysoo requested a review from ndcunningham May 26, 2023 14:46
lerna.json Outdated Show resolved Hide resolved
@jaysoo jaysoo merged commit 3634abb into nrwl:master May 26, 2023
@jaysoo jaysoo deleted the fix/js-lib-standalone branch May 26, 2023 16:11
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants