-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): allow root js lib project to be generated #17245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
fix/js-lib-standalone
branch
from
May 26, 2023 15:00
6a4636a
to
3d3e2c5
Compare
AgentEnder
reviewed
May 26, 2023
jaysoo
force-pushed
the
fix/js-lib-standalone
branch
from
May 26, 2023 15:38
3d3e2c5
to
1a58a79
Compare
ndcunningham
approved these changes
May 26, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rootProject: true
option for@nx/js:lib
doesn't actually work. Main two problems are:tsconfig.base.json
is still generated even if no other projects are present to require it.nx build
will fail if@nx/js:swc
is used because it doesn't work when the project is at the root.
.@types/node
package, which is required to build libs.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #