Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle empty scripts in nx init #17238

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 26, 2023

Current Behavior

Running nx init in a repo where there are no scripts in the package.json throws. It also throws in an Angular CLI workspace with no targets (more of an edge case).

Expected Behavior

Running nx init in a repo where there are no scripts in the package.json should not throw.
Running nx init in an Angular CLI workspace with no targets should not throw.

Related Issue(s)

Fixes #17234

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 8:09am

@leosvelperez leosvelperez enabled auto-merge (squash) May 26, 2023 10:23
@leosvelperez leosvelperez merged commit 99afe11 into nrwl:master May 26, 2023
@leosvelperez leosvelperez deleted the core/nx-init-handle-empty-scripts branch May 26, 2023 14:31
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx nx init breaking
3 participants