Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): add cssCodeSplit in build options #17213

Merged
merged 1 commit into from
May 25, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

Vite build.cssCodeSplit is hard-coded to true.

Expected Behavior

Allow setting of cssCodeSplit from executor options. If not set, vite.config.ts setting is used.

Related Issue(s)

Fixes #17037

@mandarini mandarini self-assigned this May 25, 2023
@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 1:34pm

@mandarini mandarini enabled auto-merge (squash) May 25, 2023 13:27
@mandarini mandarini force-pushed the feat/support-cssCodesplit branch from bc80ed2 to c72cde7 Compare May 25, 2023 13:27
@mandarini mandarini merged commit 636b911 into nrwl:master May 25, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cssCodeSplitting: true isn't overridable
2 participants