Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): set NX_NEXT_DIR when running next server #17205

Merged
merged 1 commit into from
May 25, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 24, 2023

We missed setting NX_NEXT_DIR when refactoring the @nx/next:server executor. This is needed for the generated Express app to work in dev mode.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 11:25pm

@ndcunningham ndcunningham merged commit 47de95e into nrwl:master May 25, 2023
@jaysoo jaysoo deleted the fix/nextjs-custom-server branch May 25, 2023 15:24
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants