Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): add --randomize flag for jest #17148

Merged
merged 1 commit into from
May 25, 2023

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented May 22, 2023

Debugging CI issue do not merge

Current Behavior

the new --randomize flag is not in the jest executor options

Expected Behavior

--randomize option is an executor option

Related Issue(s)

Fixes #17115

TODO:

  • this came in v29.5.0, but we support v29.x what happens for those < v29.5.x 🤔
    • the flag just does nothing. so should not break anything. also jest-preset-angular has a min of v29.5.0 anyways so most people are probably already there if they are on latest

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 7:11pm

@nx-cloud
Copy link

nx-cloud bot commented May 22, 2023

@barbados-clemens barbados-clemens force-pushed the fix/add-rand-jest-flag branch from ff17f74 to e9daeb8 Compare May 22, 2023 15:42
@barbados-clemens barbados-clemens self-assigned this May 22, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label May 22, 2023
@barbados-clemens barbados-clemens marked this pull request as ready for review May 22, 2023 19:17
@barbados-clemens barbados-clemens enabled auto-merge (squash) May 22, 2023 19:37
@barbados-clemens barbados-clemens force-pushed the fix/add-rand-jest-flag branch from 2eb1e06 to 5943397 Compare May 23, 2023 14:24
@barbados-clemens barbados-clemens force-pushed the fix/add-rand-jest-flag branch from 5943397 to aad1b31 Compare May 23, 2023 14:51
@barbados-clemens barbados-clemens disabled auto-merge May 23, 2023 15:27
@barbados-clemens barbados-clemens marked this pull request as draft May 23, 2023 15:27
@barbados-clemens barbados-clemens force-pushed the fix/add-rand-jest-flag branch from aad1b31 to 68f09b1 Compare May 23, 2023 16:37
@barbados-clemens barbados-clemens force-pushed the fix/add-rand-jest-flag branch from 68f09b1 to 867e96a Compare May 23, 2023 18:07
@barbados-clemens barbados-clemens force-pushed the fix/add-rand-jest-flag branch from 867e96a to 7f08f51 Compare May 23, 2023 18:53
@barbados-clemens barbados-clemens force-pushed the fix/add-rand-jest-flag branch from 7f08f51 to 426c679 Compare May 23, 2023 19:48
@barbados-clemens barbados-clemens force-pushed the fix/add-rand-jest-flag branch from e8013d2 to 8aa6b40 Compare May 24, 2023 18:59
@barbados-clemens barbados-clemens marked this pull request as ready for review May 24, 2023 20:40
@barbados-clemens barbados-clemens enabled auto-merge (squash) May 24, 2023 20:41
@AgentEnder AgentEnder disabled auto-merge May 25, 2023 14:57
@AgentEnder AgentEnder merged commit 2ed8bbf into nrwl:master May 25, 2023
@barbados-clemens barbados-clemens deleted the fix/add-rand-jest-flag branch May 25, 2023 15:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new jest --randomize flag
3 participants