feat(core): expose the task graph in the executor context #17111
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
| @@ -36,7 +28,8 @@ export function convertNxExecutor(executor: Executor) { | |||
| projectsConfigurations, | |||
| nxJsonConfiguration, | |||
| cwd: process.cwd(), | |||
| projectGraph, | |||
| projectGraph: null, | |||
There was a problem hiding this comment.
Why are we not passing in the project graph anymore?
There was a problem hiding this comment.
This is in line with another change @vsavkin did on a separate PR (for some reason, we have convertNxExecutor in nx and in devkit). I just aligned the devkit implementation with the change done in the nx one. I asked Victor about that change, and the reasoning is that if you have a builder in an Angular CLI project, there is no meaningful project graph because you aren’t in an Nx workspace and our invariants won’t hold.
There was a problem hiding this comment.
Ok, interesting. We had a todo comment about marking the project graph as required in the interface there, we should make sure docs around the compat layer mention that the field will be undefined for Ng CLI workspaces.
There was a problem hiding this comment.
Agreed. Overall, the docs around Nx and Angular need a good review and more details about the integration and caveats. I have that on my list of things to do. This is not the only thing that's not documented properly.
leosvelperez
force-pushed
the
core/expose-task-graph-in-executor-context
branch
from
8d10c2b to
53b5e39
Compare
leosvelperez
force-pushed
the
core/expose-task-graph-in-executor-context
branch
2 times, most recently
from
e5a19d4 to
cfbce73
Compare
leosvelperez
force-pushed
the
core/expose-task-graph-in-executor-context
branch
from
cfbce73 to
54ca2ec
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The task graph of the current execution is not accessible from executors.
Expected Behavior
The task graph of the current execution is accessible from executors as part of the
ExecutorContext. This is helpful for accessing already parsed task dependencies and acting on them.Related Issue(s)
Fixes #