Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update package-manager utils to normalize yarn-path when migrating #17088

Merged
merged 1 commit into from
May 24, 2023

Conversation

AgentEnder
Copy link
Member

Current Behavior

When we copy over project level .yarnrc and .yarnrc.yml files they may contain yarn-path or yarnPath respectively. This is a relative path from the old location to a yarn binary that yarn calls instead of the global install version.

Since we copy the files wholesale with no edits, these paths no longer exist in the temp directory.

Expected Behavior

We write a modified yarn config file that normalizes paths to the actual location.

Related Issue(s)

Fixes #17023

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2023 10:17pm

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-nx-workspace failed to initialize using yarn as the packageManager
1 participant