fix(core): tree should not be changed after committed to disk in migrations

[AgentEnder]

Current Behavior

It is hard to debug when a migration writes to the tree after it has been committed. This only occurs when an async statement is not awaited or similar issues with promises, and the migration is assumed to be complete. As such, the warning that you get is in the middle of other migrations and its hard to track down which migration actually has the issue.

This changes how the logs are created to include more context to make the experience nicer.

Expected Behavior

"Changed after committed" warnings include the reason the tree was created.

Related Issue(s)

Fixes #17064

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2023 4:34pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c0a55f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx affected -t e2e-macos --parallel=1 --base= --head=

---

Sent with 💌 from NxCloud.

[rcfox]

Maybe it would be worth adding eslint rules to catch these improperly-handled promises as well? :)

    ...
    {
      "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
      "rules": {
        ...
        "@typescript-eslint/no-floating-promises": "error",
        "@typescript-eslint/no-misused-promises": ["error"],
        ...

• https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-floating-promises.md
• https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-misused-promises.md

[AgentEnder]

File changes have already been written to disk...

Go ahead and make this an error.

[leosvelperez]

nit:

Suggested change

	title: `File changes have already been written to disk. Further changes were attempted ${
	this.logOperationId ? `while running ${this.logOperationId}.` : '.'
	}`,
	title: `File changes have already been written to disk. Further changes were attempted${
	this.logOperationId ? ` while running ${this.logOperationId}.` : '.'
	}`,

[leosvelperez]

Now there's no previous mention of the tree. I think the It here lacks context about what it's referring to.

Suggested change

	'It can no longer be modified. This commonly happens when a generator attempts to make further ',
	'The tree can no longer be modified. This commonly happens when a generator attempts to make further ',

[leosvelperez]

Splitting a single sentence into multiple lines can make the sentence split weirdly in the terminal when the terminal is narrower than the parts. I think it's better not to break a sentence into various lines.

[AgentEnder]

Sure, that makes sense.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.