Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add missing await when processing task for batches #17027

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 15, 2023

Current Behavior

The processTaskForBatches function in the TaskSchedule class was made async in #15684 but a recursive call was missed and not updated to await the execution.

Expected Behavior

Calls to the processTaskForBatches function in the TaskSchedule class that are not meant to execute in parallel should await the execution.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 3:08pm

@FrozenPandaz FrozenPandaz merged commit 5141c9f into nrwl:master May 15, 2023
@leosvelperez leosvelperez deleted the core/missing-await-task-schedule branch May 16, 2023 07:23
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants