fix(core): normalize path in tree when accessing recorded changes #17016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When filtering deleted files in the
children
function of theTree
, the paths are not normalized. In Windows, this prevents the files to match so thechildren
function returns deleted files.Expected Behavior
The paths used to access the recorded changes in the
Tree
should always be normalized. Fixing this caused another issue to surface. Thedelete
function was not handling the root dir correctly and causing an infinite loop (an edge case where there are no files in the root).Related Issue(s)
Fixes #17011