Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add error when root project would be '.' #16999

Merged
merged 1 commit into from
May 12, 2023

Conversation

AgentEnder
Copy link
Member

Current Behavior

If the root package.json is an Nx project, and it doesn't contain a name, you end up with a project called "." This is technically fine, but is pretty confusing behavior wise.

Expected Behavior

It errors

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 9:37pm

@FrozenPandaz FrozenPandaz merged commit 024193f into nrwl:master May 12, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants