fix(web): provide free port to http-server #16917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
added
the
scope: testing tools
barbados-clemens
force-pushed
the
fix/web-file-server-port
branch
from
bdfb56a to
a5c66ff
Compare
barbados-clemens
force-pushed
the
fix/web-file-server-port
branch
from
a5c66ff to
a20dafa
Compare
barbados-clemens
force-pushed
the
fix/web-file-server-port
branch
from
a20dafa to
4acd68b
Compare
barbados-clemens
force-pushed
the
fix/web-file-server-port
branch
from
4acd68b to
2a45ed1
Compare
barbados-clemens
force-pushed
the
fix/web-file-server-port
branch
from
2a45ed1 to
bded998
Compare
barbados-clemens
changed the title
barbados-clemens
requested review from
jaysoo,
mandarini and
ndcunningham
as code owners
mandarini
approved these changes
May 19, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nx/web:file-server doesn't return the port used by http-server if the port is already in use.
Expected Behavior
@nx/web:file-server returns the port value used by http-server by providing a known free port.
Related Issue(s)
Fixes #16684