-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add commandExternalDependencies hash input #16916
Merged
FrozenPandaz
merged 8 commits into
nrwl:master
from
meeroslav:feat-add-command-external-dependencies
May 15, 2023
Merged
feat(core): add commandExternalDependencies hash input #16916
FrozenPandaz
merged 8 commits into
nrwl:master
from
meeroslav:feat-add-command-external-dependencies
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
changed the title
feat(core): add unit tests
feat(core): add commandExternalDependencies hash input
May 10, 2023
meeroslav
force-pushed
the
feat-add-command-external-dependencies
branch
from
May 10, 2023 20:14
34b41d3
to
f59df43
Compare
meeroslav
force-pushed
the
feat-add-command-external-dependencies
branch
from
May 11, 2023 08:17
f59df43
to
9108c9d
Compare
meeroslav
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
May 11, 2023 11:33
meeroslav
force-pushed
the
feat-add-command-external-dependencies
branch
from
May 11, 2023 11:34
9108c9d
to
5a75a32
Compare
meeroslav
force-pushed
the
feat-add-command-external-dependencies
branch
from
May 12, 2023 11:32
5a75a32
to
6caefc2
Compare
meeroslav
force-pushed
the
feat-add-command-external-dependencies
branch
from
May 12, 2023 17:29
f60a4fa
to
28cf4f1
Compare
meeroslav
force-pushed
the
feat-add-command-external-dependencies
branch
from
May 12, 2023 18:18
ea0aabc
to
9a359e0
Compare
meeroslav
force-pushed
the
feat-add-command-external-dependencies
branch
from
May 14, 2023 22:36
9a359e0
to
0f7d524
Compare
isaacplmann
requested changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs clearer documentation
isaacplmann
approved these changes
May 15, 2023
FrozenPandaz
approved these changes
May 15, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #16903
This PR implements new
commandExternalDependencies
inputCurrent Behavior
Expected Behavior
Related Issue(s)
Solution for #15116