Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add commandExternalDependencies hash input #16916

Merged

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented May 10, 2023

Follow up to #16903

This PR implements new commandExternalDependencies input

Current Behavior

Expected Behavior

Related Issue(s)

Solution for #15116

@meeroslav meeroslav self-assigned this May 10, 2023
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 2:52pm

@meeroslav meeroslav changed the title feat(core): add unit tests feat(core): add commandExternalDependencies hash input May 10, 2023
@meeroslav meeroslav force-pushed the feat-add-command-external-dependencies branch from 34b41d3 to f59df43 Compare May 10, 2023 20:14
@meeroslav meeroslav force-pushed the feat-add-command-external-dependencies branch from f59df43 to 9108c9d Compare May 11, 2023 08:17
@meeroslav meeroslav added type: feature scope: core core nx functionality labels May 11, 2023
@meeroslav meeroslav marked this pull request as ready for review May 11, 2023 11:33
@meeroslav meeroslav force-pushed the feat-add-command-external-dependencies branch from 9108c9d to 5a75a32 Compare May 11, 2023 11:34
@meeroslav meeroslav force-pushed the feat-add-command-external-dependencies branch from 5a75a32 to 6caefc2 Compare May 12, 2023 11:32
@meeroslav meeroslav force-pushed the feat-add-command-external-dependencies branch from f60a4fa to 28cf4f1 Compare May 12, 2023 17:29
@meeroslav meeroslav force-pushed the feat-add-command-external-dependencies branch from ea0aabc to 9a359e0 Compare May 12, 2023 18:18
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs clearer documentation

docs/shared/reference/project-configuration.md Outdated Show resolved Hide resolved
docs/shared/reference/project-configuration.md Outdated Show resolved Hide resolved
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) May 15, 2023 14:47
@FrozenPandaz FrozenPandaz merged commit f5ae995 into nrwl:master May 15, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants