Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): warn in ng-packagr executors when finding conflicting package export conditions #16905

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 10, 2023

Current Behavior

When conflicting package exports are found, an error is thrown.

Expected Behavior

When conflicting package exports are found, a warning should be logged.

Note: This commit is a sync from an upstream change in ng-packagr.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this May 10, 2023
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) May 10, 2023 10:33am

@leosvelperez leosvelperez marked this pull request as ready for review May 10, 2023 10:35
@leosvelperez leosvelperez requested a review from Coly010 as a code owner May 10, 2023 10:35
@leosvelperez leosvelperez merged commit bdfb10d into nrwl:master May 10, 2023
@leosvelperez leosvelperez deleted the angular/ng-packagr-warn-conflicting-export-conditions branch May 10, 2023 11:55
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants